Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: sdk/lib/html/html_common/conversions_dart2js.dart

Issue 1490463003: Don't use ".catch" in dart2js generated code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/js_ast/lib/src/printer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/html_common/conversions_dart2js.dart
diff --git a/sdk/lib/html/html_common/conversions_dart2js.dart b/sdk/lib/html/html_common/conversions_dart2js.dart
index 3b3a8adf3960f50b75bda109d7907acb1a2bd577..b7f3d7cbbccfd7604bb0b754bdbab6a95468147a 100644
--- a/sdk/lib/html/html_common/conversions_dart2js.dart
+++ b/sdk/lib/html/html_common/conversions_dart2js.dart
@@ -88,7 +88,7 @@ Future convertNativePromiseToDartFuture(promise) {
var completer = new Completer();
var then = convertDartClosureToJS((result) => completer.complete(result), 1);
var error = convertDartClosureToJS((result) => completer.completeError(result), 1);
- var newPromise = JS('', '#.then(#).catch(#)', promise, then, error);
+ var newPromise = JS('', '#.then(#)["catch"](#)', promise, then, error);
return completer.future;
}
« no previous file with comments | « pkg/js_ast/lib/src/printer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698