Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1490383002: Clean up use of encode/decode in the ARM integrated assembler. (Closed)

Created:
5 years ago by Karl
Modified:
5 years ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean up use of encode/decode in the ARM integrated assembler. Cleans up function names containing "decode" and "encode". Change "encode" to represent the conversion of values into bit-sequences, as they appear in instructions. Change "decode" to represent the extraction of values from bit sequences. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=676e73f3e7cdba6bd51e9583c69b1f551bc0bd4f

Patch Set 1 #

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -89 lines) Patch
M src/IceAssemblerARM32.cpp View 1 32 chunks +90 lines, -89 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Karl
5 years ago (2015-12-02 19:09:22 UTC) #3
Jim Stichnoth
lgtm
5 years ago (2015-12-02 21:10:05 UTC) #4
Karl
5 years ago (2015-12-02 22:20:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
676e73f3e7cdba6bd51e9583c69b1f551bc0bd4f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698