Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1490343002: PPC: Pad InterpreterEntryTrampoline end with bkpt instruction. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Pad InterpreterEntryTrampoline end with bkpt instruction. While execution will not return to this location, stack iteration logic will attempt to find the code object associated with the return address. This makes sure that it maps to the correct object and not to the one immediately following it in memory. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/37c145580e46e8b4b7001729a6dd82d950a86999 Cr-Commit-Position: refs/heads/master@{#32526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/ppc/builtins-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
5 years ago (2015-12-02 17:16:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490343002/1
5 years ago (2015-12-02 17:16:50 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 17:37:35 UTC) #5
michael_dawson
On 2015/12/02 17:37:35, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-12-02 17:40:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490343002/1
5 years ago (2015-12-02 17:49:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 17:53:24 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-02 17:54:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37c145580e46e8b4b7001729a6dd82d950a86999
Cr-Commit-Position: refs/heads/master@{#32526}

Powered by Google App Engine
This is Rietveld 408576698