Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ppc/builtins-ppc.cc

Issue 1490343002: PPC: Pad InterpreterEntryTrampoline end with bkpt instruction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 840 matching lines...) Expand 10 before | Expand all | Expand 10 after
851 851
852 // Dispatch to the first bytecode handler for the function. 852 // Dispatch to the first bytecode handler for the function.
853 __ lbzx(r4, MemOperand(kInterpreterBytecodeArrayRegister, 853 __ lbzx(r4, MemOperand(kInterpreterBytecodeArrayRegister,
854 kInterpreterBytecodeOffsetRegister)); 854 kInterpreterBytecodeOffsetRegister));
855 __ ShiftLeftImm(ip, r4, Operand(kPointerSizeLog2)); 855 __ ShiftLeftImm(ip, r4, Operand(kPointerSizeLog2));
856 __ LoadPX(ip, MemOperand(kInterpreterDispatchTableRegister, ip)); 856 __ LoadPX(ip, MemOperand(kInterpreterDispatchTableRegister, ip));
857 // TODO(rmcilroy): Make dispatch table point to code entrys to avoid untagging 857 // TODO(rmcilroy): Make dispatch table point to code entrys to avoid untagging
858 // and header removal. 858 // and header removal.
859 __ addi(ip, ip, Operand(Code::kHeaderSize - kHeapObjectTag)); 859 __ addi(ip, ip, Operand(Code::kHeaderSize - kHeapObjectTag));
860 __ Call(ip); 860 __ Call(ip);
861 __ bkpt(0); // Does not return here.
861 } 862 }
862 863
863 864
864 void Builtins::Generate_InterpreterExitTrampoline(MacroAssembler* masm) { 865 void Builtins::Generate_InterpreterExitTrampoline(MacroAssembler* masm) {
865 // TODO(rmcilroy): List of things not currently dealt with here but done in 866 // TODO(rmcilroy): List of things not currently dealt with here but done in
866 // fullcodegen's EmitReturnSequence. 867 // fullcodegen's EmitReturnSequence.
867 // - Supporting FLAG_trace for Runtime::TraceExit. 868 // - Supporting FLAG_trace for Runtime::TraceExit.
868 // - Support profiler (specifically decrementing profiling_counter 869 // - Support profiler (specifically decrementing profiling_counter
869 // appropriately and calling out to HandleInterrupts if necessary). 870 // appropriately and calling out to HandleInterrupts if necessary).
870 871
(...skipping 1108 matching lines...) Expand 10 before | Expand all | Expand 10 after
1979 __ bkpt(0); 1980 __ bkpt(0);
1980 } 1981 }
1981 } 1982 }
1982 1983
1983 1984
1984 #undef __ 1985 #undef __
1985 } // namespace internal 1986 } // namespace internal
1986 } // namespace v8 1987 } // namespace v8
1987 1988
1988 #endif // V8_TARGET_ARCH_PPC 1989 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698