Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 149023008: Call SwapImports on x64 builds too. (Closed)

Created:
6 years, 10 months ago by Cait (Slow)
Modified:
6 years, 10 months ago
Reviewers:
csharp, robertshield
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Call SwapImports on x64 builds too. BUG=335173 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249859

Patch Set 1 #

Patch Set 2 : reenable test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M build/win/reorder-imports.py View 1 chunk +12 lines, -9 lines 0 comments Download
M chrome_elf/elf_imports_unittest.cc View 1 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Cait (Slow)
csharp: PTAL at python changes robertshield: unittest changes. Thanks!
6 years, 10 months ago (2014-02-07 21:12:07 UTC) #1
csharp
python lgtm
6 years, 10 months ago (2014-02-07 21:20:50 UTC) #2
robertshield
unit tests LGTM
6 years, 10 months ago (2014-02-07 21:23:39 UTC) #3
Cait (Slow)
The CQ bit was checked by caitkp@chromium.org
6 years, 10 months ago (2014-02-07 21:24:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/149023008/30001
6 years, 10 months ago (2014-02-07 21:26:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/149023008/30001
6 years, 10 months ago (2014-02-07 22:24:20 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-08 00:08:20 UTC) #7
Message was sent while issue was closed.
Change committed as 249859

Powered by Google App Engine
This is Rietveld 408576698