Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Unified Diff: build/win/reorder-imports.py

Issue 149023008: Call SwapImports on x64 builds too. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: reenable test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome_elf/elf_imports_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/win/reorder-imports.py
diff --git a/build/win/reorder-imports.py b/build/win/reorder-imports.py
index da0a09a353e9d0872067001b8e6932a4f55ecf18..616ae35fb9153feccb0ef9625dc7020b9a6fdce9 100755
--- a/build/win/reorder-imports.py
+++ b/build/win/reorder-imports.py
@@ -19,16 +19,19 @@ def reorder_imports(input_dir, output_dir, architecture):
input_image = os.path.join(input_dir, 'chrome.exe')
output_image = os.path.join(output_dir, 'chrome.exe')
- # TODO(caitkp): Remove this once swapimport works on x64 builds.
+ swap_exe = os.path.join(
+ __file__,
+ '..\\..\\..\\third_party\\syzygy\\binaries\\exe\\swapimport.exe')
+
+ args = [swap_exe, '--input-image=%s' % input_image,
+ '--output-image=%s' % output_image, '--overwrite']
+
if architecture == 'x64':
- shutil.copy(input_image, output_image)
- else:
- swap_exe = os.path.join(
- __file__,
- '..\\..\\..\\third_party\\syzygy\\binaries\\exe\\swapimport.exe')
- subprocess.call(
- [swap_exe, '--input-image=%s' % input_image,
- '--output-image=%s' % output_image, '--overwrite', 'chrome_elf.dll'])
+ args.append('--x64');
+
+ args.append('chrome_elf.dll');
+
+ subprocess.call(args)
for fname in glob.iglob(os.path.join(input_dir, 'chrome.exe.*')):
shutil.copy(fname, os.path.join(output_dir, os.path.basename(fname)))
« no previous file with comments | « no previous file | chrome_elf/elf_imports_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698