Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1490203003: [Cronet] Set HTTP method before starting a request in CronetHttpURLConnection (Closed)

Created:
5 years ago by xunjieli
Modified:
5 years ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Set HTTP method before starting a request in CronetHttpURLConnection This CL sets the HTTP method before starting a request in CronetHttpURLConnection. R=pauljensen@chromium.org BUG=561678 Committed: https://crrev.com/326fe63459502b7689da481cd4262e23dfa240b7 Cr-Commit-Position: refs/heads/master@{#362980}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
xunjieli
Paul, PTAL.
5 years ago (2015-12-02 23:33:52 UTC) #1
pauljensen
lgtm https://codereview.chromium.org/1490203003/diff/1/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java File components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java (right): https://codereview.chromium.org/1490203003/diff/1/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java#newcode285 components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java:285: // Set HttpMethod. nit: HttpMethod->HTTP method
5 years ago (2015-12-03 02:38:47 UTC) #2
xunjieli
Thanks! https://codereview.chromium.org/1490203003/diff/1/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java File components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java (right): https://codereview.chromium.org/1490203003/diff/1/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java#newcode285 components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java:285: // Set HttpMethod. On 2015/12/03 02:38:47, pauljensen wrote: ...
5 years ago (2015-12-03 14:45:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490203003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490203003/20001
5 years ago (2015-12-03 14:45:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 14:57:28 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-03 14:58:09 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/326fe63459502b7689da481cd4262e23dfa240b7
Cr-Commit-Position: refs/heads/master@{#362980}

Powered by Google App Engine
This is Rietveld 408576698