Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java

Issue 1490203003: [Cronet] Set HTTP method before starting a request in CronetHttpURLConnection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
index d6ea1c88f8e3bf6b503c4665dea5695f3466d3fc..f4964735c38ac35c61fa0a4daf6ce1e3201550de 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
@@ -72,6 +72,23 @@ public class CronetHttpURLConnectionTest extends CronetTestBase {
urlConnection.disconnect();
}
+ @SmallTest
+ @Feature({"Cronet"})
+ @CompareDefaultWithCronet
+ // Regression test for crbug.com/561678.
+ public void testSetRequestMethod() throws Exception {
+ URL url = new URL(NativeTestServer.getEchoMethodURL());
+ HttpURLConnection connection = (HttpURLConnection) url.openConnection();
+ connection.setDoOutput(true);
+ connection.setRequestMethod("PUT");
+ OutputStream out = connection.getOutputStream();
+ out.write("dummy data".getBytes());
+ assertEquals(200, connection.getResponseCode());
+ assertEquals("OK", connection.getResponseMessage());
+ assertEquals("PUT", getResponseAsString(connection));
+ connection.disconnect();
+ }
+
/**
* Tests that using reflection to find {@code fixedContentLengthLong} works.
*/
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698