Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1490193003: [Password Manager] Update Confirmation UI for saved password change for Chrome on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index f0dabfa3f24fbc6e3617e02fab9c7ec37b9994c1..34433d7e084385c5cce97816e5ad8ebc1094dfd1 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -66,6 +66,7 @@
#include "chrome/browser/android/tab_android.h"
#include "chrome/browser/password_manager/account_chooser_dialog_android.h"
#include "chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.h"
+#include "chrome/browser/password_manager/update_password_infobar_delegate.h"
#include "chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.h"
#endif
@@ -240,6 +241,13 @@ bool ChromePasswordManagerClient::PromptUserToSaveOrUpdatePassword(
#if defined(OS_MACOSX) || BUILDFLAG(ANDROID_JAVA_UI)
if (form_to_save->IsBlacklisted())
return false;
+#if BUILDFLAG(ANDROID_JAVA_UI)
+ if (update_password && IsUpdatePasswordUIEnabled()) {
+ UpdatePasswordInfoBarDelegate::Create(web_contents(),
+ std::move(form_to_save));
+ return true;
+ }
+#endif
std::string uma_histogram_suffix(
password_manager::metrics_util::GroupIdToString(
password_manager::metrics_util::MonitoredDomainGroupId(
@@ -567,8 +575,12 @@ bool ChromePasswordManagerClient::IsTheHotNewBubbleUIEnabled() {
}
bool ChromePasswordManagerClient::IsUpdatePasswordUIEnabled() const {
- // Currently Password update UI is implemented only for Bubble UI.
+#if BUILDFLAG(ANDROID_JAVA_UI)
+ return base::FeatureList::IsEnabled(
+ password_manager::features::kEnablePasswordChangeSupport);
+#else
return IsTheHotNewBubbleUIEnabled();
+#endif
}
bool ChromePasswordManagerClient::EnabledForSyncSignin() {

Powered by Google App Engine
This is Rietveld 408576698