Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/app/generated_resources.grd

Issue 1490193003: [Password Manager] Update Confirmation UI for saved password change for Chrome on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« chrome/android/java/strings/android_chrome_strings.grd ('K') | « chrome/android/java/strings/android_chrome_strings.grd ('k') | chrome/browser/android/chrome_jni_registrar.cc » ('j') | chrome/browser/password_manager/update_password_infobar_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 37430912defc2448a87c841d15abef029fec08c6..a88fa035a5871661e33c3b8d2c1c1dda3454269d 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -7283,6 +7283,9 @@ Keep your key file in a safe place. You will need it to create new versions of y
</message>
<!-- Password Manager -->
+ <message name="IDS_PASSWORD_MANAGER_CANCEL_BUTTON" desc="Text for the 'Manage Passwords' bubble's 'Not now' option">
Peter Kasting 2016/02/13 01:44:52 Clarify for the translators what this does, how lo
melandory 2016/02/22 12:41:09 Done.
+ Nope
Peter Kasting 2016/02/13 01:44:52 If this is intended to be colloquial, you should i
melandory 2016/02/22 12:41:09 Checked with our PM. It shouldn't be marked as col
+ </message>
<message name="IDS_FILL_ON_ACCOUNT_SELECT_NAME" desc="Name of the experiment for the password manager to fill on account selection rather than page load">
Fill passwords on account selection
</message>
@@ -7308,9 +7311,6 @@ Keep your key file in a safe place. You will need it to create new versions of y
<message name="IDS_PASSWORD_MANAGER_BUBBLE_BLACKLIST_BUTTON" desc="Button text for the 'Save Password' bubble's 'Never remember for this site' option">
Never
</message>
- <message name="IDS_PASSWORD_MANAGER_CANCEL_BUTTON" desc="Text for the 'Manage Passwords' bubble's 'Not now' option">
- Nope
- </message>
<message name="IDS_PASSWORD_MANAGER_TOOLTIP_SAVE" desc="Text for the 'Manage Passwords' icon's 'password to be saved' state">
Save your password
</message>
@@ -7325,6 +7325,9 @@ Keep your key file in a safe place. You will need it to create new versions of y
<message name="IDS_PASSWORD_MANAGER_BLACKLIST_BUTTON" desc="Mobile: Button text for the 'Save Password' infobar's 'Never remember for this site' option">
Never
</message>
+ <message name="IDS_PASSWORD_MANAGER_UPDATE_BUTTON" desc="Update button text for password manager">
Peter Kasting 2016/02/13 01:44:52 Again, this description tells me little to nothing
melandory 2016/02/22 12:41:09 Done.
+ Update
+ </message>
</if>
<!-- Android uses custom UI for Bookmark importing -->
« chrome/android/java/strings/android_chrome_strings.grd ('K') | « chrome/android/java/strings/android_chrome_strings.grd ('k') | chrome/browser/android/chrome_jni_registrar.cc » ('j') | chrome/browser/password_manager/update_password_infobar_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698