Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 1490113006: Add all components to "gn check". (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tim+watch_chromium.org, ozone-reviews_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add all components to "gn check". All components now pass a "gn check" step. Whitelist with a wildcard. R=dpranke@chromium.org Reland of https://codereview.chromium.org/1491743002 Committed: https://crrev.com/3b5cac24943ce9e682c806f844a6aec90481774c Cr-Commit-Position: refs/heads/master@{#362776}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -161 lines) Patch
M .gn View 1 chunk +1 line, -152 lines 0 comments Download
M components/arc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/wayland/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/version_info/version_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/wifi_sync/BUILD.gn View 2 chunks +18 lines, -7 lines 0 comments Download
M ui/ozone/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
brettw
.
5 years ago (2015-12-02 17:49:10 UTC) #1
brettw
Delta from last landing is nogncheck annotation in version_info.cc
5 years ago (2015-12-02 17:49:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490113006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490113006/20001
5 years ago (2015-12-02 17:50:14 UTC) #4
Dirk Pranke
lgtm
5 years ago (2015-12-02 17:54:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/148809)
5 years ago (2015-12-02 18:26:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490113006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490113006/20001
5 years ago (2015-12-02 18:35:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 19:45:02 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3b5cac24943ce9e682c806f844a6aec90481774c Cr-Commit-Position: refs/heads/master@{#362776}
5 years ago (2015-12-02 19:48:39 UTC) #14
gab
5 years ago (2015-12-02 20:33:53 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1491273003/ by gab@chromium.org.

The reason for reverting is: Breaks Linux ChromeOS GN:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

Log: 
/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/buildtools/linux64/gn gen
//out/Debug '--args=target_os="chromeos" is_debug=true is_component_build=true
use_goma=true goma_dir="/b/build/goma"' --check
--runtime-deps-list-file=/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/out/Debug/runtime_deps
  -> returned 1
ERROR Unresolved dependencies.
//ui/ozone:ozone(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone(//build/toolchain/linux:clang_x64)
//ui/ozone/platform/drm:gbm(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone_evdev(//build/toolchain/linux:clang_x64)
//ui/ozone/platform/egltest:egltest(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone_evdev(//build/toolchain/linux:clang_x64).

Powered by Google App Engine
This is Rietveld 408576698