Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1490103003: Adding CHECK(false) for case when input audio fails to start on Mac (Closed)

Created:
5 years ago by henrika (OOO until Aug 14)
Modified:
5 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding CHECK(false) for case when input audio fails to start on Mac BUG=549021 Committed: https://crrev.com/cbe08a1dda4438af98648a0a35f2797d5a265c19 Cr-Commit-Position: refs/heads/master@{#362697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M media/audio/mac/audio_low_latency_input_mac.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
henrika (OOO until Aug 14)
As discussed. PTAL
5 years ago (2015-12-02 12:00:17 UTC) #3
tommi (sloooow) - chröme
This is intended for a single canary, right? assuming we'll revert as soon as we ...
5 years ago (2015-12-02 13:21:44 UTC) #4
henrika (OOO until Aug 14)
Yes, I just need a few crashes and then I will revert.
5 years ago (2015-12-02 13:24:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490103003/1
5 years ago (2015-12-02 13:25:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 13:53:05 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cbe08a1dda4438af98648a0a35f2797d5a265c19 Cr-Commit-Position: refs/heads/master@{#362697}
5 years ago (2015-12-02 13:54:03 UTC) #11
henrika (OOO until Aug 14)
5 years ago (2015-12-08 09:14:28 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1504993003/ by henrika@chromium.org.

The reason for reverting is: Have not been able to catch any crashes in 6 days
and keeping this CHECK prevents us from making real changes. Will revert and
possibly try this approach at a later stage if needed..

Powered by Google App Engine
This is Rietveld 408576698