Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: media/audio/mac/audio_low_latency_input_mac.cc

Issue 1490103003: Adding CHECK(false) for case when input audio fails to start on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/mac/audio_low_latency_input_mac.cc
diff --git a/media/audio/mac/audio_low_latency_input_mac.cc b/media/audio/mac/audio_low_latency_input_mac.cc
index a50acf99a0196483eb4569e502cd21f97ae94217..22a0455e313277bc31b9f396a6e0fa7d53f5a059 100644
--- a/media/audio/mac/audio_low_latency_input_mac.cc
+++ b/media/audio/mac/audio_low_latency_input_mac.cc
@@ -769,6 +769,11 @@ void AUAudioInputStream::CheckInputStartupSuccess() {
// Now when we know that startup has failed for some reason, add extra
// UMA stats in an attempt to figure out the exact reason.
AddHistogramsForFailedStartup();
+ // Kill the browser and create a crash log. This is just a temporary
+ // test (intended for Canary) where the goal is to gather some more
+ // detailed stats about how and why we can hit this problem.
+ // See crbug.com/549021 for details.
+ CHECK(false);
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698