Make JS-form 'returns:' annotation imply 'creates:' unless otherwise specified

Make JS-form 'returns:' annotation imply 'creates:' unless otherwise specified

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/ce03676eba8b1c01ff21987520c63a0cad099684

[sra1, 2015-12-02 01:18:04]

Patchset #1 (id:1) has been deleted

[sra1, 2015-12-02 01:18:10]

Patchset #1 (id:20001) has been deleted

[sra1, 2015-12-02 01:18:17]

Patchset #1 (id:40001) has been deleted

[sra1, 2015-12-02 01:19:17]

sra@google.com changed reviewers:
+ sigmund@google.com

[sra1, 2015-12-02 01:19:18]

I just spent an hour debugging what was a missing creates:.
I think this default is safer.

[Siggi Cherem (dart-lang), 2015-12-02 02:21:06]

Lgtm.

We don't seem to have any tests for returns:dynamic, could we add some?

https://codereview.chromium.org/1490103002/diff/60001/tests/compiler/dart2js/...
File tests/compiler/dart2js/js_spec_string_test.dart (right):

https://codereview.chromium.org/1490103002/diff/60001/tests/compiler/dart2js/...
tests/compiler/dart2js/js_spec_string_test.dart:71: Expect.isFalse(expectError,
'Missinge error for "$specString".');
Missinge => missing

[sra1, 2015-12-03 02:01:54]

'returns:dynamic' is the same as 'returns:A'.

The lookup us mocked via

    resolveType: (t) => t,

https://codereview.chromium.org/1490103002/diff/60001/tests/compiler/dart2js/...
File tests/compiler/dart2js/js_spec_string_test.dart (right):

https://codereview.chromium.org/1490103002/diff/60001/tests/compiler/dart2js/...
tests/compiler/dart2js/js_spec_string_test.dart:71: Expect.isFalse(expectError,
'Missinge error for "$specString".');
On 2015/12/02 02:21:06, Siggi Cherem (dart-lang) wrote:
> Missinge => missing

Done.

[sra1, 2015-12-03 02:45:58]

Description was changed from

==========
Make JS-form 'returns:' annotation imply 'creates:' unless otherwise specified
==========

to

==========
Make JS-form 'returns:' annotation imply 'creates:' unless otherwise specified

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ce03676eba8b1c01ff21987520c63a0cad099684
==========

[sra1, 2015-12-03 02:45:59]

Committed patchset #2 (id:80001) manually as
ce03676eba8b1c01ff21987520c63a0cad099684 (presubmit successful).