Make JS-form 'returns:' annotation imply 'creates:' unless otherwise specified

tests/compiler/dart2js/js_spec_string_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Unit test of the [NativeBehavior.processSpecString] method.
 
 import 'package:expect/expect.dart';
 import 'package:compiler/src/native/native.dart';
 import 'package:compiler/src/diagnostics/diagnostic_listener.dart';
 import 'package:compiler/src/diagnostics/messages.dart';
@@ skipping 46 matching lines @@
         null,
         specString,
         setSideEffects: (effects) { actualSideEffects = effects; },
         setThrows: (b) { actualThrows = b; },
         setIsAllocation: (b) { actualNew = b; },
         setUseGvn: (b) { actualGvn = b; },
         resolveType: (t) => t,
         typesReturned: actualReturns, typesInstantiated: actualCreates,
         objectType: OBJECT, nullType: NULL);
   } catch (e) {
-    Expect.isTrue(expectError);
-    Expect.isNotNull(listener.errorMessage, 'Error expected.');
+    Expect.isTrue(expectError, 'Unexpected error "$specString"');
+    Expect.isNotNull(listener.errorMessage, 'Error message expected.');
     return;
   }
+  Expect.isFalse(expectError, 'Missing error for "$specString".');
   Expect.isNull(listener.errorMessage, 'Unexpected error.');
   if (returns != null) {
     Expect.listEquals(returns, actualReturns, 'Unexpected returns.');
   }
   if (creates != null) {
     Expect.listEquals(creates, actualCreates, 'Unexpected creates.');
   }
   Expect.equals(expectedSideEffects, actualSideEffects);
   Expect.equals(expectedThrows, actualThrows);
   Expect.equals(expectedNew, actualNew);
@@ skipping 129 matching lines @@
   test('void', returns: [], creates: []);
   test('', returns: [OBJECT, NULL], creates: []);
   test('var', returns: [OBJECT, NULL], creates: []);
   test('A', returns: ['A'], creates: ['A']);
   test('A|B', returns: ['A', 'B'], creates: ['A', 'B']);
   test('A|B|C', returns: ['A', 'B', 'C'], creates: ['A', 'B', 'C']);
 
   test('returns:void;', returns: [], creates: []);
   test('returns:;', returns: [OBJECT, NULL], creates: []);
   test('returns:var;', returns: [OBJECT, NULL], creates: []);
-  test('returns:A;', returns: ['A'], creates: []);
-  test('returns:A|B;', returns: ['A', 'B'], creates: []);
-  test('returns:A|B|C;', returns: ['A', 'B', 'C'], creates: []);
+  test('returns:A;', returns: ['A'], creates: ['A']);
+  test('returns:A|B;', returns: ['A', 'B'], creates: ['A', 'B']);
+  test('returns:A|B|C;', returns: ['A', 'B', 'C'], creates: ['A', 'B', 'C']);
 
   test('creates:void;', expectError: true);
-  test('creates:;', expectError: true);
-  test('creates:var;', expectError: true);
+  test('creates:;', creates: []);
+  test('creates:var;', creates: []);
   test('creates:A;', returns: [], creates: ['A']);
   test('creates:A|B;', returns: [], creates: ['A', 'B']);
   test('creates:A|B|C;', returns: [], creates: ['A', 'B', 'C']);
 
+  test('returns:void;creates:', returns: [], creates: []);
+  test('returns:;creates:', returns: [OBJECT, NULL], creates: []);
+  test('returns:var;creates:', returns: [OBJECT, NULL], creates: []);
+  test('returns:A;creates:', returns: ['A'], creates: []);
+  test('returns:A|B;creates:;', returns: ['A', 'B'], creates: []);
+  test('returns:A|B|C;creates:;', returns: ['A', 'B', 'C'], creates: []);
+
   test('returns:void;creates:A;', returns: [], creates: ['A']);
   test('returns:;creates:A|B;', returns: [OBJECT, NULL], creates: ['A', 'B']);
   test('returns:var;creates:A|B|C;',
       returns: [OBJECT, NULL], creates: ['A', 'B', 'C']);
   test('returns:A; creates:A|B|C; ', returns: ['A'], creates: ['A', 'B', 'C']);
   test(' returns:A|B;  creates:A|C;',
       returns: ['A', 'B'], creates: ['A', 'C']);
   test(' returns:A|B|C;   creates:A;  ',
       returns: ['A', 'B', 'C'], creates: ['A']);
 
   testWithSideEffects('returns:void;', returns: [], creates: []);
   testWithSideEffects('returns:void;', returns: [], creates: []);
   testWithSideEffects('returns:;', returns: [OBJECT, NULL], creates: []);
   testWithSideEffects('returns:var;', returns: [OBJECT, NULL], creates: []);
-  testWithSideEffects('returns:A;', returns: ['A'], creates: []);
-  testWithSideEffects('returns:A|B;', returns: ['A', 'B'], creates: []);
-  testWithSideEffects('returns:A|B|C;', returns: ['A', 'B', 'C'], creates: []);
+  testWithSideEffects('returns:A;', returns: ['A'], creates: ['A']);
+  testWithSideEffects('returns:A|B;',
+      returns: ['A', 'B'], creates: ['A', 'B']);
+  testWithSideEffects('returns:A|B|C;',
+      returns: ['A', 'B', 'C'], creates: ['A', 'B', 'C']);
   testWithSideEffects('returns: A| B |C ;',
-      returns: ['A', 'B', 'C'], creates: []);
+      returns: ['A', 'B', 'C'], creates: ['A', 'B', 'C']);
 
   testWithSideEffects('creates:void;', expectError: true);
-  testWithSideEffects('creates:;', expectError: true);
-  testWithSideEffects('creates:var;', expectError: true);
+  testWithSideEffects('creates:;', creates: []);
+  testWithSideEffects('creates:var;', creates: []);
   testWithSideEffects('creates:A;', returns: [], creates: ['A']);
   testWithSideEffects('creates:A|B;', returns: [], creates: ['A', 'B']);
   testWithSideEffects('creates:A|B|C;', returns: [], creates: ['A', 'B', 'C']);
 
+  testWithSideEffects('returns:void;creates:;', returns: [], creates: []);
+  testWithSideEffects('returns:;creates:;',
+      returns: [OBJECT, NULL], creates: []);
+  testWithSideEffects('returns:var;creates:;',
+      returns: [OBJECT, NULL], creates: []);
+  testWithSideEffects('returns:A;creates:;', returns: ['A'], creates: []);
+  testWithSideEffects('returns:A|B;creates:;',
+      returns: ['A', 'B'], creates: []);
+  testWithSideEffects('returns:A|B|C;creates:;',
+      returns: ['A', 'B', 'C'], creates: []);
+
   testWithSideEffects('returns:void;creates:A;', returns: [], creates: ['A']);
   testWithSideEffects('returns:;creates:A|B;',
       returns: [OBJECT, NULL], creates: ['A', 'B']);
   testWithSideEffects('returns:var;creates:A|B|C;',
       returns: [OBJECT, NULL], creates: ['A', 'B', 'C']);
   testWithSideEffects('returns:A; creates:A|B|C; ',
       returns: ['A'], creates: ['A', 'B', 'C']);
   testWithSideEffects(' returns:A|B;  creates:A|C;',
       returns: ['A', 'B'], creates: ['A', 'C']);
   testWithSideEffects(' returns:A|B|C;   creates:A;  ',
@@ skipping 16 matching lines @@
   test('gvn:false', expectedGvn: false);
   test('returns:A;gvn:true', returns: ['A'], expectedGvn: true);
   test(' gvn : true ;  returns:A;', returns: ['A'], expectedGvn: true);
   test('gvn:true;returns:A;gvn:true', expectError: true);
 
   test('gvn: true; new: true', expectError: true);
   test('gvn: true; new: false', expectedGvn: true, expectedNew: false);
   test('gvn: false; new: true', expectedGvn: false, expectedNew: true);
   test('gvn: false; new: false', expectedGvn: false, expectedNew: false);
 }