Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-border-in-fr.html

Issue 1490093003: [css-grid] Fix items' height computation in indefinite grids with fr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch for landing Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-border-in-fr.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-border-in-fr.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-border-in-fr.html
new file mode 100644
index 0000000000000000000000000000000000000000..4436a950f5baaafe8b7804565c12c1d29a727f14
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-border-in-fr.html
@@ -0,0 +1,66 @@
+<!DOCTYPE html>
+
+<link href="resources/grid.css" rel="stylesheet">
+<link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel="stylesheet">
+<style>
+.frGrid {
+ grid: 1fr / 1fr;
+ font: 50px/1 Ahem;
+ border: 50px solid magenta;
+ width: 300px;
+}
+
+.item {
+ border: 50px solid rgba(0, 255, 250, 0.5);
+}
+
+.borderMargin {
+ border: 20px solid blue;
+ margin: 30px;
+}
+
+.frRowsGrid {
+ grid-auto-columns: 100px;
+ grid-auto-rows: minmax(0,1fr);
+}
+
+.frColsGrid {
+ grid-auto-columns: minmax(0,1fr);
+ grid-auto-rows: 100px;
+}
+
+span {
+ background: yellow;
+ border: 10px solid;
+}
+
+.child {
+ height:40px;
+ width:40px;
+}
+
+</style>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<script src="../../resources/check-layout-th.js"></script>
+
+<body onload="checkLayout('.grid')">
+<div id=log></div>
+
+<div class="grid frGrid" data-expected-width="400" data-expected-height="250" data-expected-client-width="300" data-expected-client-height="150">
+ <div class="item" data-expected-width="300" data-expected-height="150" data-expected-client-width="200" data-expected-client-height="50">X</div>
+</div>
+
+<div class="grid borderMargin fit-content frRowsGrid" data-expected-width="140" data-expected-height="100" data-expected-client-width="100" data-expected-client-height="60">
+ <span data-expected-width="100" data-expected-height="60" data-expected-client-width="80" data-expected-client-height="40">
+ <div class="child"></div>
+ </span>
+</div>
+
+<div class="grid borderMargin fit-content frColsGrid" data-expected-width="100" data-expected-height="140" data-expected-client-width="60" data-expected-client-height="100">
+ <span data-expected-width="60" data-expected-height="100" data-expected-client-width="40" data-expected-client-height="80">
+ <div class="child"></div>
+ </span>
+</div>
+
+</body>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698