Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Issue 1490093003: [css-grid] Fix items' height computation in indefinite grids with fr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch for landing Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-border-in-fr.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutGrid.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
index 7845f1a21ce696aad804d7584757828754ad86e5..e5cccec8f0e74be8cbc103d4da6f27eed34c8a42 100644
--- a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
@@ -377,7 +377,7 @@ void LayoutGrid::layoutBlock(bool relayoutChildren)
// The above call might have changed the grid's logical height depending on min|max height restrictions.
// Update the sizes of the rows whose size depends on the logical height (also on definite|indefinite sizes).
if (logicalHeightWasIndefinite)
- computeTrackSizesForDirection(ForRows, sizingData, logicalHeight());
+ computeTrackSizesForDirection(ForRows, sizingData, contentLogicalHeight());
// Grid container should have the minimum height of a line if it's editable. That doesn't affect track sizing though.
if (hasLineIfEmpty())
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-border-in-fr.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698