Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutInline.h

Issue 1490063002: Implement Paint Containment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unnecessary adjustStyleForContainment declaration Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutInline.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutInline.h b/third_party/WebKit/Source/core/layout/LayoutInline.h
index ff0ca351074860087e3e3fdd4598b85da997928d..7c8d94cad4e68a73210c6a686d905119e87ba1bd 100644
--- a/third_party/WebKit/Source/core/layout/LayoutInline.h
+++ b/third_party/WebKit/Source/core/layout/LayoutInline.h
@@ -228,7 +228,12 @@ private:
bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) final;
- PaintLayerType layerTypeRequired() const override { return isInFlowPositioned() || createsGroup() || hasClipPath() || style()->shouldCompositeForCurrentAnimations() || style()->hasCompositorProxy() ? NormalPaintLayer : NoPaintLayer; }
+ PaintLayerType layerTypeRequired() const override
chrishtr 2015/12/09 01:41:46 I think this method should be un-inlined at this p
leviw_travelin_and_unemployed 2015/12/09 21:09:24 Done and...
+ {
+ // TODO(leviw): Should this create an OverflowPaintLayer with containsPaint()?
chrishtr 2015/12/09 01:41:46 I think no. Stacking contexts should be self-paint
leviw_travelin_and_unemployed 2015/12/09 21:09:24 ... done.
+ return isInFlowPositioned() || createsGroup() || hasClipPath() || style()->shouldCompositeForCurrentAnimations()
+ || style()->hasCompositorProxy() || style()->containsPaint() ? NormalPaintLayer : NoPaintLayer;
+ }
LayoutUnit offsetLeft() const final;
LayoutUnit offsetTop() const final;

Powered by Google App Engine
This is Rietveld 408576698