third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 1490063002: Implement Paint Containment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1490063002: Implement Paint Containment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove unnecessary adjustStyleForContainment declaration Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index e6f84ffc8f017c8b309cf4d2372e5466b4420738..d724bd16080724d109982ef4ffead15d4cb46941 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -107,7 +107,7 @@ PaintLayerType LayoutBox::layerTypeRequired() const

|| !style()->hasAutoZIndex() || style()->shouldCompositeForCurrentAnimations())

chrishtr 2015/12/09 01:41:46 !hasAutoZIndex should be enough, line 110 will be

leviw_travelin_and_unemployed 2015/12/09 21:09:24 Good point :)

return NormalPaintLayer;

- if (hasOverflowClip())

+ if (hasOverflowClip() || style()->containsPaint())

return OverflowClipPaintLayer;

return NoPaintLayer;