GN(android): Adds extra_native_libs_even_when_incremental to create_apk()

GN(android): Adds extra_native_libs_even_when_incremental to create_apk()

For incremental targets, gdbserver should still be packaged in the apk rather than side-loaded.

BUG=559289
Committed: https://crrev.com/8db972584e6fa8bae80be8a1bc8923afb692cd2b
Cr-Commit-Position: refs/heads/master@{#362523}

[agrieve, 2015-12-01 15:38:23]

Description was changed from

==========
GN(android): Adds extra_native_libs_even_when_incremental to create_apk()

Required for gdbserver and loadable_modules

BUG=559289
==========

to

==========
GN(android): Adds extra_native_libs_even_when_incremental to create_apk()

Required for gdbserver and loadable_modules

BUG=559289
==========

[agrieve, 2015-12-01 15:38:23]

agrieve@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[agrieve, 2015-12-01 15:38:40]

On 2015/12/01 15:38:23, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:pkotwicz@chromium.org

ᶘᵒᴥᵒᶅ

[pkotwicz, 2015-12-01 16:50:15]

LGTM

Please describe why this change is necessary for gdbserver in the CL
description.

There is not much point discussing "loadable_modules" in the CL description
because the "loadable_modules CL" has not yet landed.

https://codereview.chromium.org/1489883002/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1489883002/diff/1/build/config/android/rules....
build/config/android/rules.gni:1632:
_extra_native_libs_even_when_incremental_deps = []
Nit: Move these outside the if statement

https://codereview.chromium.org/1489883002/diff/1/build/config/android/rules....
build/config/android/rules.gni:1793: }
Please add a comment why |_extra_native_libs_even_when_incremental_deps| is not
passed to this rule.

I understand why, but the reason is confusing

[agrieve, 2015-12-01 16:59:02]

Description was changed from

==========
GN(android): Adds extra_native_libs_even_when_incremental to create_apk()

Required for gdbserver and loadable_modules

BUG=559289
==========

to

==========
GN(android): Adds extra_native_libs_even_when_incremental to create_apk()

For incremental targets, gdbserver should still be packaged in the apk rather
than side-loaded.

BUG=559289
==========

[agrieve, 2015-12-01 17:57:37]

Updated CL description

https://codereview.chromium.org/1489883002/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1489883002/diff/1/build/config/android/rules....
build/config/android/rules.gni:1632:
_extra_native_libs_even_when_incremental_deps = []
On 2015/12/01 16:50:14, pkotwicz wrote:
> Nit: Move these outside the if statement

Causes "goes out of scope without being used" errors :S

https://codereview.chromium.org/1489883002/diff/1/build/config/android/rules....
build/config/android/rules.gni:1793: }
On 2015/12/01 16:50:14, pkotwicz wrote:
> Please add a comment why |_extra_native_libs_even_when_incremental_deps| is
not
> passed to this rule.
> 
> I understand why, but the reason is confusing

Done.

[agrieve, 2015-12-01 18:53:49]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-12-01 18:53:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/1489883002/#ps20001
(title: "add comment")

[commit-bot: I haz the power, 2015-12-01 18:54:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1489883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1489883002/20001

[commit-bot: I haz the power, 2015-12-01 19:11:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-01 19:11:06]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[agrieve, 2015-12-01 20:57:48]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-12-01 20:58:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1489883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1489883002/20001

[commit-bot: I haz the power, 2015-12-01 22:12:39]

Description was changed from

==========
GN(android): Adds extra_native_libs_even_when_incremental to create_apk()

For incremental targets, gdbserver should still be packaged in the apk rather
than side-loaded.

BUG=559289
==========

to

==========
GN(android): Adds extra_native_libs_even_when_incremental to create_apk()

For incremental targets, gdbserver should still be packaged in the apk rather
than side-loaded.

BUG=559289
==========

[commit-bot: I haz the power, 2015-12-01 22:12:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-01 22:13:41]

Description was changed from

==========
GN(android): Adds extra_native_libs_even_when_incremental to create_apk()

For incremental targets, gdbserver should still be packaged in the apk rather
than side-loaded.

BUG=559289
==========

to

==========
GN(android): Adds extra_native_libs_even_when_incremental to create_apk()

For incremental targets, gdbserver should still be packaged in the apk rather
than side-loaded.

BUG=559289

Committed: https://crrev.com/8db972584e6fa8bae80be8a1bc8923afb692cd2b
Cr-Commit-Position: refs/heads/master@{#362523}
==========

[commit-bot: I haz the power, 2015-12-01 22:13:42]

Patchset 2 (id:??) landed as
https://crrev.com/8db972584e6fa8bae80be8a1bc8923afb692cd2b
Cr-Commit-Position: refs/heads/master@{#362523}