Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 14898002: Add LayerTreeHostSettings for synchronous compositor (Closed)

Created:
7 years, 7 months ago by boliu
Modified:
7 years, 7 months ago
Reviewers:
jamesr, Sami
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Add cc option to non-lazily disable vsync notification The option will be used by Android WebView using synchronous compositor which requires this behavior that conflicts with other platforms. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198510

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Address comments #

Total comments: 4

Patch Set 4 : #

Total comments: 3

Patch Set 5 : rename setting #

Patch Set 6 : remove blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -12 lines) Patch
M cc/scheduler/vsync_time_source.h View 1 2 3 chunks +13 lines, -2 lines 0 comments Download
M cc/scheduler/vsync_time_source.cc View 1 2 3 chunks +15 lines, -8 lines 0 comments Download
M cc/scheduler/vsync_time_source_unittest.cc View 1 2 2 chunks +27 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/thread_proxy.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
boliu
Coding up one way to disable some compositor vsync optimizations that won't work for webview. ...
7 years, 7 months ago (2013-05-03 03:17:34 UTC) #1
jamesr
If you don't want to treat input events as vsync, have the event-is-vsync flag set ...
7 years, 7 months ago (2013-05-03 05:00:18 UTC) #2
Sami
On 2013/05/03 05:00:18, jamesr wrote: > If you don't want to treat input events as ...
7 years, 7 months ago (2013-05-03 10:58:37 UTC) #3
boliu
Removed input event vsync change; will do that in content in separate patch as suggested. ...
7 years, 7 months ago (2013-05-03 16:39:14 UTC) #4
Sami
Fair enough. Let's just make sure the BeginFrame changes will actually work for you guys ...
7 years, 7 months ago (2013-05-03 17:02:55 UTC) #5
boliu
https://codereview.chromium.org/14898002/diff/5001/cc/scheduler/vsync_time_source.h File cc/scheduler/vsync_time_source.h (right): https://codereview.chromium.org/14898002/diff/5001/cc/scheduler/vsync_time_source.h#newcode37 cc/scheduler/vsync_time_source.h:37: VSyncProvider* vsync_provider, bool lazy_disable); On 2013/05/03 17:02:55, Sami wrote: ...
7 years, 7 months ago (2013-05-03 17:20:39 UTC) #6
Sami
https://codereview.chromium.org/14898002/diff/11001/cc/scheduler/vsync_time_source.cc File cc/scheduler/vsync_time_source.cc (right): https://codereview.chromium.org/14898002/diff/11001/cc/scheduler/vsync_time_source.cc#newcode7 cc/scheduler/vsync_time_source.cc:7: #include "base/logging.h" Not needed? https://codereview.chromium.org/14898002/diff/11001/content/renderer/render_widget.h File content/renderer/render_widget.h (right): https://codereview.chromium.org/14898002/diff/11001/content/renderer/render_widget.h#newcode212 ...
7 years, 7 months ago (2013-05-03 17:55:33 UTC) #7
boliu
https://codereview.chromium.org/14898002/diff/11001/cc/scheduler/vsync_time_source.cc File cc/scheduler/vsync_time_source.cc (right): https://codereview.chromium.org/14898002/diff/11001/cc/scheduler/vsync_time_source.cc#newcode7 cc/scheduler/vsync_time_source.cc:7: #include "base/logging.h" On 2013/05/03 17:55:33, Sami wrote: > Not ...
7 years, 7 months ago (2013-05-03 17:59:39 UTC) #8
Sami
Thanks, lgtm.
7 years, 7 months ago (2013-05-03 18:02:55 UTC) #9
boliu
James: Friendly ping!
7 years, 7 months ago (2013-05-03 21:04:06 UTC) #10
jamesr
I think having a general "this is a different mode" setting for crap to be ...
7 years, 7 months ago (2013-05-03 21:07:16 UTC) #11
boliu
On 2013/05/03 21:07:16, jamesr wrote: > I think having a general "this is a different ...
7 years, 7 months ago (2013-05-03 21:30:16 UTC) #12
jamesr
lgtm
7 years, 7 months ago (2013-05-06 16:59:29 UTC) #13
boliu
Thanks James. Updated the description too.
7 years, 7 months ago (2013-05-06 17:14:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/14898002/26001
7 years, 7 months ago (2013-05-06 17:15:14 UTC) #15
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 19:43:15 UTC) #16
Message was sent while issue was closed.
Change committed as 198510

Powered by Google App Engine
This is Rietveld 408576698