Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1489683002: Improve GN asmflags help. (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
Nico
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve GN asmflags help. Hooks up asmflags to the "gn help" overview (the INSERT_VARIABLE line was missing). Reference asmflags from the cflag help, and include flag ordering information on the asmflags help. Committed: https://crrev.com/fde26f231be483ca7b25d89503e0c76ff70cda97 Cr-Commit-Position: refs/heads/master@{#362279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M tools/gn/variables.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
brettw
5 years ago (2015-11-30 22:01:12 UTC) #2
Nico
lgtm, thanks!
5 years ago (2015-11-30 22:04:47 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489683002/1
5 years ago (2015-11-30 22:06:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489683002/1
5 years ago (2015-11-30 22:16:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 23:54:09 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-30 23:54:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fde26f231be483ca7b25d89503e0c76ff70cda97
Cr-Commit-Position: refs/heads/master@{#362279}

Powered by Google App Engine
This is Rietveld 408576698