Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: tools/gn/variables.cc

Issue 1489683002: Improve GN asmflags help. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/variables.cc
diff --git a/tools/gn/variables.cc b/tools/gn/variables.cc
index 7898273fee24085d7085fb9033d551e2df2cec9c..3b1f7b194056b651e7ea6e6ff20892c13f215b1d 100644
--- a/tools/gn/variables.cc
+++ b/tools/gn/variables.cc
@@ -404,23 +404,24 @@ const char kCommonCflagsHelp[] =
"\n"
" To target one of these variants individually, use \"cflags_c\",\n"
" \"cflags_cc\", \"cflags_objc\", and \"cflags_objcc\",\n"
- " respectively.\n"
+ " respectively. These variant-specific versions of cflags* will be\n"
+ " appended on the compiler command line after \"cflags\".\n"
"\n"
- " These variant-specific versions of cflags* will be appended to the\n"
- " \"cflags\".\n"
+ " See also \"asmflags\" for flags for assembly-language files.\n"
COMMON_ORDERING_HELP;
const char* kCflags_Help = kCommonCflagsHelp;
const char kAsmflags[] = "asmflags";
const char kAsmflags_HelpShort[] =
- "asmflags: [string list] Flags passed to any assembly compiler.";
+ "asmflags: [string list] Flags passed to the assembler.";
const char* kAsmflags_Help =
- "asmflags: Flags passed to any assembly compiler.\n"
+ "asmflags: Flags passed to the assembler.\n"
"\n"
" A list of strings.\n"
"\n"
" \"asmflags\" are passed to any invocation of a tool that takes an\n"
- " .asm or .S file as input.\n";
+ " .asm or .S file as input.\n"
+ COMMON_ORDERING_HELP;
const char kCflagsC[] = "cflags_c";
const char kCflagsC_HelpShort[] =
@@ -1390,6 +1391,7 @@ const VariableInfoMap& GetTargetVariables() {
INSERT_VARIABLE(AllDependentConfigs)
INSERT_VARIABLE(AllowCircularIncludesFrom)
INSERT_VARIABLE(Args)
+ INSERT_VARIABLE(Asmflags)
INSERT_VARIABLE(Cflags)
INSERT_VARIABLE(CflagsC)
INSERT_VARIABLE(CflagsCC)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698