third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h - Issue 1489663003: column-span:all in nested multicol requires re-insertion of fragmentainer groups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

Issue 1489663003: column-span:all in nested multicol requires re-insertion of fragmentainer groups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/multicol/span/nested-multicol-expected.html ('K') | « third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp ('k') | third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

diff --git a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

index e0e1f4933b9d26feeaf218abeba1f3ab86df07b1..c68d35c8fa593f0e5fbb204e798da818608a75b5 100644

--- a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

+++ b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

@@ -60,7 +60,7 @@ public:

LayoutUnit logicalHeightInFlowThread() const { return m_logicalBottomInFlowThread - m_logicalTopInFlowThread; }

void resetColumnHeight();

- bool recalculateColumnHeight(BalancedColumnHeightCalculation calculationMode);

+ bool recalculateColumnHeight();

LayoutSize flowThreadTranslationAtOffset(LayoutUnit offsetInFlowThread) const;

LayoutUnit columnLogicalTopForOffset(LayoutUnit offsetInFlowThread) const;