Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 14894006: Make v8 compilable without V8_USE_UNSAFE_HANDLES. (Closed)

Created:
7 years, 7 months ago by marja
Modified:
7 years, 7 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Make v8 compilable without V8_USE_UNSAFE_HANDLES. Without this modification, we get this error: "dereferencing type-punned pointer will break strict-aliasing rules" (GCC strict aliasing). Also included small CcTest sanity fixes: isolate() cannot return anything else than default_isolate(). BUG= TBR=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14554

Patch Set 1 #

Total comments: 7

Patch Set 2 : Code review (dcarney) #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M test/cctest/cctest.h View 1 2 3 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcarney
https://codereview.chromium.org/14894006/diff/1/test/cctest/cctest.h File test/cctest/cctest.h (right): https://codereview.chromium.org/14894006/diff/1/test/cctest/cctest.h#newcode92 test/cctest/cctest.h:92: return context()->GetIsolate(); store the isolate instead when the context ...
7 years, 7 months ago (2013-05-06 11:40:17 UTC) #1
marja
https://codereview.chromium.org/14894006/diff/1/test/cctest/cctest.h File test/cctest/cctest.h (right): https://codereview.chromium.org/14894006/diff/1/test/cctest/cctest.h#newcode92 test/cctest/cctest.h:92: return context()->GetIsolate(); On 2013/05/06 11:40:17, dcarney wrote: > store ...
7 years, 7 months ago (2013-05-06 12:14:23 UTC) #2
dcarney
lgtm
7 years, 7 months ago (2013-05-06 12:39:18 UTC) #3
dcarney
7 years, 7 months ago (2013-05-06 13:01:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r14554 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698