Make v8 compilable without V8_USE_UNSAFE_HANDLES.

test/cctest/cctest.h

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 69 matching lines @@
   static CcTest* last() { return last_; }
   CcTest* prev() { return prev_; }
   const char* file() { return file_; }
   const char* name() { return name_; }
   const char* dependency() { return dependency_; }
   bool enabled() { return enabled_; }
   static void set_default_isolate(v8::Isolate* default_isolate) {
     default_isolate_ = default_isolate;
   }
   static v8::Isolate* default_isolate() { return default_isolate_; }
-  static v8::Isolate* isolate() { return context()->GetIsolate(); }
+  static v8::Isolate* isolate() {
+    v8::HandleScope handle_scope;
+    return context()->GetIsolate();

[dcarney, 2013/05/06 11:40:17]

store the isolate instead when the context is set

[marja, 2013/05/06 12:14:23]

Removed this function, used default_isolate() instead, and made
set_default_isolate private. This was unnecessary, since isolate() cannot return
anything else than default_isolate_.

+  }
+
+  // You need to have a valid HandleScope before calling this function.

[dcarney, 2013/05/06 11:40:17]

skip the comment

[marja, 2013/05/06 12:14:23]

Done.

   static v8::Handle<v8::Context> env() { return context(); }
 
   // Helper function to initialize the VM.
   static void InitializeVM(CcTestExtensionFlags extensions = NO_EXTENSIONS);
 
  private:
   static v8::Handle<v8::Context> context() {
-      return *reinterpret_cast<v8::Handle<v8::Context>*>(&context_);
+    return v8::Local<v8::Context>::New(v8::Isolate::GetCurrent(), context_);

[dcarney, 2013/05/06 11:40:17]

use the context isolate
also, just inline this function

[marja, 2013/05/06 12:14:23]

Done.

[marja, 2013/05/06 12:14:23]

Done.

   }
   TestFunction* callback_;
   const char* file_;
   const char* name_;
   const char* dependency_;
   bool enabled_;
   CcTest* prev_;
   static CcTest* last_;
   static v8::Isolate* default_isolate_;
   static v8::Persistent<v8::Context> context_;
@@ skipping 177 matching lines @@
 static inline void SimulateFullSpace(v8::internal::PagedSpace* space) {
   int old_linear_size = static_cast<int>(space->limit() - space->top());
   space->Free(space->top(), old_linear_size);
   space->SetTop(space->limit(), space->limit());
   space->ResetFreeList();
   space->ClearStats();
 }
 
 
 #endif  // ifndef CCTEST_H_