V8 Buildbot: Properly set revision property for triggered tryjobs.

scripts/slave/recipe_modules/v8/api.py

Index: scripts/slave/recipe_modules/v8/api.py
diff --git a/scripts/slave/recipe_modules/v8/api.py b/scripts/slave/recipe_modules/v8/api.py
index 1775ba98a641aa01bf765741688eaeddb89faae9..05d7ef853b6054e5d19cd39592c18bd20e04f261 100644
--- a/scripts/slave/recipe_modules/v8/api.py
+++ b/scripts/slave/recipe_modules/v8/api.py
@@ -1003,7 +1003,6 @@ class V8Api(recipe_api.RecipeApi):
     triggers = self.bot_config.get('triggers')
     if triggers:
       properties = {
-        'revision': self.revision,
         'parent_got_revision': self.revision,
         'parent_got_revision_cp': self.revision_cp,
       }
@@ -1014,8 +1013,13 @@ class V8Api(recipe_api.RecipeApi):
           patch_storage=str(self.m.properties['patch_storage']),
           patchset=str(self.m.properties['patchset']),
           requester=str(self.m.properties['requester']),
+          revision=str(self.m.properties.get('revision', 'HEAD')),
           rietveld=str(self.m.properties['rietveld']),
         )
+      else:
+        # Don't set revision on tryservers, as CQ expects builders and
+        # testers to match the revision field.

[tandrii(chromium), 2015/12/02 17:13:04]

this is confusing because it's in the "else" block ===== not a tryserver. And
the revision seems set in either case - above and below.

[Michael Achenbach, 2015/12/02 17:36:00]

Improved my comments.

[tandrii(chromium), 2015/12/02 17:39:46]

yep, very readable now.

+        properties['revision'] = self.revision
       swarm_hashes = self.m.isolate.isolated_tests
       if swarm_hashes:
         properties['swarm_hashes'] = swarm_hashes