Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 1489253003: Format argument of CompressedTexSubImage2D should match format of texture being modified (Closed)

Created:
5 years ago by qiankun
Modified:
5 years ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Format argument of CompressedTexSubImage2D should match format of texture being modified This restriction was lifted in https://codereview.chromium.org/1257823006. But ES3 still has this restriction. Move this check after format validation before data validation due to format is used for data validation. BUG=295792 TEST=deqp/functional/gles3/negativetextureapi.html Committed: https://crrev.com/2497feaf12020d3e652fd1056d44468c966e9cb5 Cr-Commit-Position: refs/heads/master@{#362928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qiankun
deqp/functional/gles3/negativetextureapi.html covers the test.
5 years ago (2015-12-02 14:55:29 UTC) #2
Zhenyao Mo
LGTM
5 years ago (2015-12-02 18:16:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489253003/1
5 years ago (2015-12-03 06:44:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 07:26:18 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-03 07:27:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2497feaf12020d3e652fd1056d44468c966e9cb5
Cr-Commit-Position: refs/heads/master@{#362928}

Powered by Google App Engine
This is Rietveld 408576698