Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1489253002: Plumb document's strict mixed content checking for RemoteFrames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: alexmos nits Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 17d8764e90f8b8d4f2b6049c8fbf9f7f0328b205..89897317395b6d3222aa993666ebec52bbe59b82 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2513,6 +2513,10 @@ void RenderFrameImpl::didChangeName(blink::WebLocalFrame* frame,
}
}
+void RenderFrameImpl::didEnforceStrictMixedContentChecking() {
+ Send(new FrameHostMsg_DidEnforceStrictMixedContentChecking(routing_id_));
+}
+
void RenderFrameImpl::didChangeSandboxFlags(blink::WebFrame* child_frame,
blink::WebSandboxFlags flags) {
Send(new FrameHostMsg_DidChangeSandboxFlags(
@@ -4182,6 +4186,9 @@ void RenderFrameImpl::SendDidCommitProvisionalLoad(
}
}
+ params.should_enforce_strict_mixed_content_checking =
+ frame->shouldEnforceStrictMixedContentChecking();
nasko 2015/12/17 17:16:33 nit: Why not put it right next to params.security_
alexmos 2015/12/17 17:43:02 Right now this is grouped together with setting th
estark 2015/12/17 22:19:11 Ok, I moved both origin and this up to where secur
+
if (frame->document().baseURL() != params.url)
params.base_url = frame->document().baseURL();

Powered by Google App Engine
This is Rietveld 408576698