Plumb document's strict mixed content checking for RemoteFrames

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 
 #include "base/auto_reset.h"
@@ skipping 2495 matching lines @@
   // can be optimized further by only sending the update if there are any
   // remote frames in the frame tree, or delaying and batching up IPCs if
   // updates are happening too frequently.
   if (SiteIsolationPolicy::AreCrossProcessFramesPossible() ||
       render_view_->renderer_preferences_.report_frame_name_changes) {
     Send(new FrameHostMsg_DidChangeName(
         routing_id_, base::UTF16ToUTF8(base::StringPiece16(name))));
   }
 }
 
+void RenderFrameImpl::didEnforceStrictMixedContentChecking() {
+  Send(new FrameHostMsg_DidEnforceStrictMixedContentChecking(routing_id_));
+}
+
 void RenderFrameImpl::didChangeSandboxFlags(blink::WebFrame* child_frame,
                                             blink::WebSandboxFlags flags) {
   Send(new FrameHostMsg_DidChangeSandboxFlags(
       routing_id_, GetRoutingIdForFrameOrProxy(child_frame), flags));
 }
 
 void RenderFrameImpl::didChangeFrameOwnerProperties(
     blink::WebFrame* child_frame,
     const blink::WebFrameOwnerProperties& frame_owner_properties) {
   Send(new FrameHostMsg_DidChangeFrameOwnerProperties(
@@ skipping 1649 matching lines @@
   // TODO(alexmos): Origins for URLs with non-standard schemes are excluded due
   // to https://crbug.com/439608 and will be replicated as unique origins.
   if (!is_swapped_out_) {
     std::string scheme = frame->document().securityOrigin().protocol().utf8();
     if (url::IsStandard(scheme.c_str(),
                         url::Component(0, static_cast<int>(scheme.length())))) {
       params.origin = frame->document().securityOrigin();
     }
   }
 
+  params.should_enforce_strict_mixed_content_checking =
+      frame->shouldEnforceStrictMixedContentChecking();

[nasko, 2015/12/17 17:16:33]

nit: Why not put it right next to params.security_info? In this location it is
not ordered by struct layout or alphabetically, so combining it with other parts
of the struct that are in the same category (security) can make it easy to look
it up later.

[alexmos, 2015/12/17 17:43:02]

Right now this is grouped together with setting the replicated origin, so if we
move this one, we should probably move the origin as well?

[estark, 2015/12/17 22:19:11]

Ok, I moved both origin and this up to where security_info is set.

+
   if (frame->document().baseURL() != params.url)
     params.base_url = frame->document().baseURL();
 
   GetRedirectChain(ds, &params.redirects);
   params.should_update_history = !ds->hasUnreachableURL() &&
       !response.isMultipartPayload() && (response.httpStatusCode() != 404);
 
   params.searchable_form_url = internal_data->searchable_form_url();
   params.searchable_form_encoding = internal_data->searchable_form_encoding();
 
@@ skipping 1268 matching lines @@
       media::ConvertToSwitchOutputDeviceCB(web_callbacks);
   scoped_refptr<media::AudioOutputDevice> device =
       AudioDeviceFactory::NewOutputDevice(routing_id_, 0, sink_id.utf8(),
                                           security_origin);
   media::OutputDeviceStatus status = device->GetDeviceStatus();
   device->Stop();
   callback.Run(status);
 }
 
 }  // namespace content