Plumb document's strict mixed content checking for RemoteFrames

content/common/frame_replication_state.h

Index: content/common/frame_replication_state.h
diff --git a/content/common/frame_replication_state.h b/content/common/frame_replication_state.h
index 37612c873f7f2ae5aa5d6a0b4dce27e43066228c..0bb4d7cd014e7d3ff262e0fd0e9b369f142e58c6 100644
--- a/content/common/frame_replication_state.h
+++ b/content/common/frame_replication_state.h
@@ -21,7 +21,8 @@ struct CONTENT_EXPORT FrameReplicationState {
   FrameReplicationState();
   FrameReplicationState(blink::WebTreeScopeType scope,
                         const std::string& name,
-                        blink::WebSandboxFlags sandbox_flags);
+                        blink::WebSandboxFlags sandbox_flags,
+                        bool should_enforce_strict_mixed_content_checking);
   ~FrameReplicationState();
 
   // Current origin of the frame. This field is updated whenever a frame
@@ -69,6 +70,11 @@ struct CONTENT_EXPORT FrameReplicationState {
   // operator.
   blink::WebTreeScopeType scope;
 
+  // True if a frame's current document should strictly block all mixed
+  // content. Updates are immediately sent to all frame proxies when in
+  // --site-per-process mode.
+  bool should_enforce_strict_mixed_content_checking;

[alexmos, 2015/12/03 20:43:26]

Does this bit need to be processed when creating new remote frames for a
FrameTreeNode?  See RenderFrameProxy::CreateFrameProxy and specifically
RenderFrameProxy::SetReplicatedState.  Here's an example where this might
matter:
- start with A.com embedding two same-site frames, F1 and F2.
- F2 sets its strict mixed content checking bit.
- F1 navigates cross-site to B.com.  That creates process B, in which we will
create a frame for F1, a proxy for the root frame, and a proxy for F2.  That
proxy for F2 should have the mixed content bit set.   I think this would matter
if we later add another B.com child frame to F2, as that will check the mixed
content bit on that F2 proxy (the new frame's parent) when doing
initSecurityContext for the new frame.

[estark, 2015/12/04 00:19:31]

Yeah, I agree with you that it's important to set the bit when creating new
remote frames. However I am setting it in SetReplicatedState()... is there
something else I need to do to wire it up?

[alexmos, 2015/12/04 23:41:11]

Ah, you're right, that case is indeed fine. :)

+
   // TODO(alexmos): Eventually, this structure can also hold other state that
   // needs to be replicated, such as frame sizing info.
 };