Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1489203002: Remove RuntimeEnabled from NotificationEventInit (Closed)

Created:
5 years ago by johnme
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Remove RuntimeEnabled from NotificationEventInit This is needed to complete the shipping of action buttons. It was accidentally not included in https://crrev.com/358304 (or https://codereview.chromium.org/1487763003). See also https://crbug.com/546006. BUG=513671 Review URL: https://codereview.chromium.org/1489773003 Cr-Commit-Position: refs/heads/master@{#362423} (cherry picked from commit a193248805c831b33d6cbd7b7ec1acf367ea74c7)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
johnme
5 years ago (2015-12-02 01:17:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
a0fc25b1ef49432274eeeb2d3297dfa11759d19c.

Powered by Google App Engine
This is Rietveld 408576698