Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1489773003:
Remove RuntimeEnabled from NotificationEventInit (Closed)
|
Created:
5 years ago by johnme Modified:
5 years ago Reviewers:
Peter Beverloo CC:
chromium-reviews, blink-reviews, Peter Beverloo Base URL:
https://chromium.googlesource.com/chromium/src.git@eventaction Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove RuntimeEnabled from NotificationEventInit
This is needed to complete the shipping of action buttons.
It was accidentally not included in https://crrev.com/358304
(or https://codereview.chromium.org/1487763003).
See also https://crbug.com/546006.
BUG=513671
Committed: https://crrev.com/a193248805c831b33d6cbd7b7ec1acf367ea74c7
Cr-Commit-Position: refs/heads/master@{#362423}
Patch Set 1 #Patch Set 2 : Rebase #
Messages
Total messages: 18 (11 generated)
johnme@chromium.org changed reviewers: + peter@chromium.org
Rather than saying "follow-up from", please include the same information in this CLs description. lgtm
Description was changed from ========== Also remove RuntimeEnabled from NotificationEventInit Follow-up to https://codereview.chromium.org/1487763003 (The RuntimeEnabled actually had no effect anyway, since they are ignored on dictionaries, so this doesn't need to be merged). BUG=513671 ========== to ========== Also remove RuntimeEnabled from NotificationEventInit This is needed to complete the shipping of action buttons. It was accidentally not included in https://crrev.com/358304 (or https://codereview.chromium.org/1487763003). This RuntimeEnabled actually had no effect anyway, due to https://crbug.com/546006, so this doesn't need to be merged. BUG=513671 ==========
Description was changed from ========== Also remove RuntimeEnabled from NotificationEventInit This is needed to complete the shipping of action buttons. It was accidentally not included in https://crrev.com/358304 (or https://codereview.chromium.org/1487763003). This RuntimeEnabled actually had no effect anyway, due to https://crbug.com/546006, so this doesn't need to be merged. BUG=513671 ========== to ========== Remove RuntimeEnabled from NotificationEventInit This is needed to complete the shipping of action buttons. It was accidentally not included in https://crrev.com/358304 (or https://codereview.chromium.org/1487763003). This RuntimeEnabled actually had no effect anyway, due to https://crbug.com/546006, so this doesn't need to be merged. BUG=513671 ==========
The CQ bit was checked by johnme@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 1487763003 Patch 20001). Please resolve the dependency and try again.
On 2015/12/01 12:36:50, Peter Beverloo wrote: > Rather than saying "follow-up from", please include the same information in this > CLs description. Done, thanks!
Description was changed from ========== Remove RuntimeEnabled from NotificationEventInit This is needed to complete the shipping of action buttons. It was accidentally not included in https://crrev.com/358304 (or https://codereview.chromium.org/1487763003). This RuntimeEnabled actually had no effect anyway, due to https://crbug.com/546006, so this doesn't need to be merged. BUG=513671 ========== to ========== Remove RuntimeEnabled from NotificationEventInit This is needed to complete the shipping of action buttons. It was accidentally not included in https://crrev.com/358304 (or https://codereview.chromium.org/1487763003). (see also https://crbug.com/546006, which limited the impact of this omission). BUG=513671 ==========
Description was changed from ========== Remove RuntimeEnabled from NotificationEventInit This is needed to complete the shipping of action buttons. It was accidentally not included in https://crrev.com/358304 (or https://codereview.chromium.org/1487763003). (see also https://crbug.com/546006, which limited the impact of this omission). BUG=513671 ========== to ========== Remove RuntimeEnabled from NotificationEventInit This is needed to complete the shipping of action buttons. It was accidentally not included in https://crrev.com/358304 (or https://codereview.chromium.org/1487763003). See also https://crbug.com/546006. BUG=513671 ==========
The CQ bit was checked by johnme@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org Link to the patchset: https://codereview.chromium.org/1489773003/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489773003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489773003/20001
Message was sent while issue was closed.
Description was changed from ========== Remove RuntimeEnabled from NotificationEventInit This is needed to complete the shipping of action buttons. It was accidentally not included in https://crrev.com/358304 (or https://codereview.chromium.org/1487763003). See also https://crbug.com/546006. BUG=513671 ========== to ========== Remove RuntimeEnabled from NotificationEventInit This is needed to complete the shipping of action buttons. It was accidentally not included in https://crrev.com/358304 (or https://codereview.chromium.org/1487763003). See also https://crbug.com/546006. BUG=513671 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove RuntimeEnabled from NotificationEventInit This is needed to complete the shipping of action buttons. It was accidentally not included in https://crrev.com/358304 (or https://codereview.chromium.org/1487763003). See also https://crbug.com/546006. BUG=513671 ========== to ========== Remove RuntimeEnabled from NotificationEventInit This is needed to complete the shipping of action buttons. It was accidentally not included in https://crrev.com/358304 (or https://codereview.chromium.org/1487763003). See also https://crbug.com/546006. BUG=513671 Committed: https://crrev.com/a193248805c831b33d6cbd7b7ec1acf367ea74c7 Cr-Commit-Position: refs/heads/master@{#362423} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a193248805c831b33d6cbd7b7ec1acf367ea74c7 Cr-Commit-Position: refs/heads/master@{#362423} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
