build/config/compiler/BUILD.gn - Issue 1489193002: Enable arm/linux chromium to build with gn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1489193002: Enable arm/linux chromium to build with gn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_bfd_linking

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 08d10a494fa019f7002074a59b999a1a7405d730..ca6533331b6f93e4c64973b129faf4fd890367ac 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -53,7 +53,7 @@ declare_args() {

# TODO(GYP): We should be using 64-bit gold for linking on both 64-bit Linux

# and 32-bit linux; 32-bit Gold runs out of address-space on 32-bit builds.

# However, something isn't quite working right on the 32-bit builds.

- use_gold = is_linux && current_cpu == "x64"

+ use_gold = is_linux && (current_cpu == "x64" || current_cpu == "arm")

# When we are going to use gold we need to find it.

# This is initialized below, after use_gold might have been overridden.

@@ -553,6 +553,7 @@ config("compiler_cpu_abi") {

"-arch",

"arm-nonsfi",

"--pnacl-bias=arm-nonsfi",

+ "--target=arm-unknown-nacl",

Mark Seaborn 2015/12/03 20:02:18 FYI, this doesn't match the Gyp build exactly. He

]

ldflags += [

"-arch",

« no previous file with comments | « no previous file | docs/linux_chromium_arm.md » ('j') | no next file with comments »