third_party/leveldatabase/BUILD.gn - Issue 1488933002: Misc fixes for gn builds with VS 2015

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/leveldatabase/BUILD.gn

Issue 1488933002: Misc fixes for gn builds with VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable warning 4267 which is the VC++ 2015 4244 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/leveldatabase/BUILD.gn

diff --git a/third_party/leveldatabase/BUILD.gn b/third_party/leveldatabase/BUILD.gn

index b3080d8a2fdb491dc4eaff9264f66ac2465cc1a3..0057c0eed73bb6fd78752fa00e598e4883d3298f 100644

--- a/third_party/leveldatabase/BUILD.gn

+++ b/third_party/leveldatabase/BUILD.gn

@@ -282,6 +282,13 @@ if (!is_android) {

deps = [

":leveldb_testutil",

]

+ if (is_win) {

+ # db\log_test.cc(486) triggers two warnings:

+ # util\testharness.h(91): warning C4018: '<=': signed/unsigned mismatch

+ # util\testharness.h(89): warning C4018: '>=': signed/unsigned mismatch

+ cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison.

+ }

}

test("leveldb_skiplist_test") {