build/config/compiler/BUILD.gn - Issue 1488933002: Misc fixes for gn builds with VS 2015

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1488933002: Misc fixes for gn builds with VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable warning 4267 which is the VC++ 2015 4244 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 6923a32f1dd4c5f8e7a02b236df2251ebcd57615..73da9b6c30683ff2158855e159160fa3d25969cd 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -741,6 +741,7 @@ config("default_warnings") {

"/wd4100", # Unreferenced formal function parameter.

"/wd4121", # Alignment of a member was sensitive to packing.

"/wd4244", # Conversion: possible loss of data.

+ "/wd4267", # Conversion: possible loss of data.

brettw 2015/12/02 18:33:59 We don't want to add this globally. jschuh spent a

"/wd4481", # Nonstandard extension: override specifier.

"/wd4505", # Unreferenced local function has been removed.

"/wd4510", # Default constructor could not be generated.

« no previous file with comments | « no previous file | google_apis/gcm/base/mcs_util_unittest.cc » ('j') | no next file with comments »