Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1488923002: Remove unused DidPageReceiveSafeBrowsingMatch code. (Closed)

Created:
5 years ago by mattm
Modified:
5 years ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused DidPageReceiveSafeBrowsingMatch code. BUG=424751 Committed: https://crrev.com/a820df1f9ba6beb8e780f3fb7cb5190da14f93d2 Cr-Commit-Position: refs/heads/master@{#363067}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -61 lines) Patch
M chrome/browser/safe_browsing/client_side_detection_host.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 2 chunks +1 line, -37 lines 2 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_tab_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_tab_observer.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mattm
5 years ago (2015-12-01 01:34:31 UTC) #2
Nathan Parker
lgtm https://codereview.chromium.org/1488923002/diff/1/chrome/browser/safe_browsing/client_side_detection_host.cc File chrome/browser/safe_browsing/client_side_detection_host.cc (right): https://codereview.chromium.org/1488923002/diff/1/chrome/browser/safe_browsing/client_side_detection_host.cc#newcode433 chrome/browser/safe_browsing/client_side_detection_host.cc:433: void ClientSideDetectionHost::OnSafeBrowsingMatch( Can this method be removed altogether ...
5 years ago (2015-12-03 17:21:20 UTC) #3
mattm
https://codereview.chromium.org/1488923002/diff/1/chrome/browser/safe_browsing/client_side_detection_host.cc File chrome/browser/safe_browsing/client_side_detection_host.cc (right): https://codereview.chromium.org/1488923002/diff/1/chrome/browser/safe_browsing/client_side_detection_host.cc#newcode433 chrome/browser/safe_browsing/client_side_detection_host.cc:433: void ClientSideDetectionHost::OnSafeBrowsingMatch( On 2015/12/03 17:21:20, nparker wrote: > Can ...
5 years ago (2015-12-03 20:38:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488923002/1
5 years ago (2015-12-03 20:39:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 21:39:25 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-03 21:40:28 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a820df1f9ba6beb8e780f3fb7cb5190da14f93d2
Cr-Commit-Position: refs/heads/master@{#363067}

Powered by Google App Engine
This is Rietveld 408576698