chrome/browser/safe_browsing/client_side_detection_host_unittest.cc - Issue 1488923002: Remove unused DidPageReceiveSafeBrowsingMatch code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

Issue 1488923002: Remove unused DidPageReceiveSafeBrowsingMatch code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/client_side_detection_host.cc ('K') | « chrome/browser/safe_browsing/client_side_detection_host.cc ('k') | chrome/browser/safe_browsing/safe_browsing_tab_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

index 2206e76ef65ecd99750247fa6e816f1b59709f5f..2cac402acb328ac1703b4a1b2e5197fd9583972b 100644

--- a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

@@ -362,11 +362,8 @@ class ClientSideDetectionHostTest : public ChromeRenderViewHostTestHarness {

GetID();

resource.render_view_id =

web_contents()->GetRenderViewHost()->GetRoutingID();

- ASSERT_FALSE(csd_host_->DidPageReceiveSafeBrowsingMatch());

csd_host_->OnSafeBrowsingMatch(resource);

- ASSERT_TRUE(csd_host_->DidPageReceiveSafeBrowsingMatch());

csd_host_->OnSafeBrowsingHit(resource);

- ASSERT_TRUE(csd_host_->DidPageReceiveSafeBrowsingMatch());

resource.callback.Reset();

ASSERT_TRUE(csd_host_->DidShowSBInterstitial());

TestUnsafeResourceCopied(resource);

@@ -397,13 +394,10 @@ class ClientSideDetectionHostTest : public ChromeRenderViewHostTestHarness {

csd_host_->OnSafeBrowsingHit(resource);

resource.callback.Reset();

- ASSERT_TRUE(csd_host_->DidPageReceiveSafeBrowsingMatch());

// LoadURL created a navigation entry, now simulate the RenderView sending

// a notification that it actually navigated.

content::WebContentsTester::For(web_contents())->CommitPendingNavigation();

- ASSERT_TRUE(csd_host_->DidPageReceiveSafeBrowsingMatch());

ASSERT_TRUE(csd_host_->DidShowSBInterstitial());

TestUnsafeResourceCopied(resource);

}

@@ -419,11 +413,9 @@ class ClientSideDetectionHostTest : public ChromeRenderViewHostTestHarness {

EXPECT_NE(web_contents()->GetRenderViewHost()->GetRoutingID(),

pending_rvh()->GetRoutingID());

}

- ASSERT_FALSE(csd_host_->DidPageReceiveSafeBrowsingMatch());

ASSERT_FALSE(csd_host_->DidShowSBInterstitial());

content::WebContentsTester::For(web_contents())->CommitPendingNavigation();

- ASSERT_FALSE(csd_host_->DidPageReceiveSafeBrowsingMatch());

ASSERT_FALSE(csd_host_->DidShowSBInterstitial());

}