ui/accessibility/ax_node_data.cc - Issue 1488893002: Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/accessibility/ax_node_data.cc

Issue 1488893002: Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test for menu checkboxes and removed indeterminate state. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/accessibility/ax_node_data.cc

diff --git a/ui/accessibility/ax_node_data.cc b/ui/accessibility/ax_node_data.cc

index c7a50051a002255e6808f238418383218a57d18d..c283d873c356cd5f564686cf03c06ee125cc212c 100644

--- a/ui/accessibility/ax_node_data.cc

+++ b/ui/accessibility/ax_node_data.cc

@@ -277,8 +277,6 @@ std::string AXNodeData::ToString() const {

result += " HASPOPUP";

if (state & (1 << AX_STATE_HOVERED))

result += " HOVERED";

- if (state & (1 << AX_STATE_INDETERMINATE))

- result += " INDETERMINATE";

if (state & (1 << AX_STATE_INVISIBLE))

result += " INVISIBLE";

if (state & (1 << AX_STATE_LINKED))

@@ -558,7 +556,7 @@ std::string AXNodeData::ToString() const {

for (size_t i = 0; i < bool_attributes.size(); ++i) {

std::string value = bool_attributes[i].second ? "true" : "false";

switch (bool_attributes[i].first) {

- case AX_ATTR_BUTTON_MIXED:

+ case AX_ATTR_CHECKBOX_MIXED:

result += " mixed=" + value;

break;

case AX_ATTR_LIVE_ATOMIC:

« content/browser/accessibility/browser_accessibility_win.cc ('K') | « ui/accessibility/ax_enums.idl ('k') | no next file » | no next file with comments »