third_party/WebKit/Source/modules/accessibility/AXNodeObject.h - Issue 1488893002: Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

Issue 1488893002: Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test for menu checkboxes and removed indeterminate state. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/accessibility/browser_accessibility_win.cc ('K') | « content/test/data/accessibility/html/input-radio-in-menu-expected-win.txt ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

index 7ce6133a55ecbc9ecb18206eafc38692a709f8a8..fd5c3a9d7966b2f7a7966908d2a8bdb839dbe979 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

@@ -123,7 +123,6 @@ protected:

bool isClickable() const final;

bool isEnabled() const override;

AccessibilityExpanded isExpanded() const override;

- bool isIndeterminate() const final;

bool isPressed() const final;

bool isReadOnly() const override;

bool isRequired() const final;

@@ -205,6 +204,7 @@ protected:

private:

RawPtrWillBeMember<Node> m_node;

+ bool isNativeCheckboxInMixedState() const;

String textFromDescendants(AXObjectSet& visited) const;

String nativeTextAlternative(AXObjectSet& visited, AXNameFrom&, AXRelatedObjectVector*, NameSources*, bool* foundTextAlternative) const;

float stepValueForRange() const;