Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148883005: patch from issue 119343003 (Closed)

Created:
6 years, 10 months ago by humper
Modified:
6 years, 10 months ago
Reviewers:
epoger, bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

patch from issue 119343003 compile on 10.6, exclude failing gms Sorry for making another CL; rebasing ToT on the old one ended up with code in a tangled mess; was easier to start over. NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13238

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Compare transformations for equality check #

Patch Set 4 : add rects to ignore list for now #

Patch Set 5 : another rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -37 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 1 chunk +18 lines, -1 line 0 comments Download
M gyp/effects.gypi View 2 chunks +1 line, -1 line 0 comments Download
M include/core/SkMaskFilter.h View 3 chunks +11 lines, -0 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/effects/SkBlurMask.h View 1 chunk +35 lines, -0 lines 0 comments Download
M src/effects/SkBlurMask.cpp View 6 chunks +36 lines, -34 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 2 3 chunks +278 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
humper
hopefully this is the one; try bots are running right now.
6 years, 10 months ago (2014-01-28 20:16:21 UTC) #1
epoger
On 2014/01/28 20:16:21, humper wrote: > hopefully this is the one; try bots are running ...
6 years, 10 months ago (2014-01-28 20:17:41 UTC) #2
bsalomon
lgtm
6 years, 10 months ago (2014-01-28 20:42:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/148883005/60001
6 years, 10 months ago (2014-01-29 15:57:53 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 15:32:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/148883005/80001
6 years, 10 months ago (2014-01-30 15:34:35 UTC) #6
commit-bot: I haz the power
Change committed as 13238
6 years, 10 months ago (2014-01-30 15:34:48 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 15:34:50 UTC) #8
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698