Issue 148883003: Change destruction order of FocusController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148883003: Change destruction order of FocusController (Closed)

Created:
6 years, 10 months ago by sky

Modified:
6 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, ben+views_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change destruction order of FocusController Currently the FocusController is destroyed after the root window. FocusController may use DesktopNativeWidgetAura::content_window_. Since the FocusController is destroyed after content_window_ it is entirely possible for FocusController to attempt to use content_window_ after it's been destroyed. This patch destroys FocusController before the root. BUG=314118 TEST=covered by test R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247568

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -6 lines)			Patch
M	ui/views/widget/desktop_aura/desktop_native_widget_aura.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_native_widget_aura.cc	View	3 chunks	+11 lines, -5 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc	View	2 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/148883003/1

6 years, 10 months ago (2014-01-28 18:39:53 UTC) #3

Message was sent while issue was closed.

Change committed as 247568

Expand Messages | Collapse Messages