Change destruction order of FocusController

ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
 
 #include "ui/aura/client/cursor_client.h"
 #include "ui/aura/root_window.h"
+#include "ui/aura/test/test_window_delegate.h"
 #include "ui/aura/window.h"
 #include "ui/views/test/views_test_base.h"
 #include "ui/views/widget/widget.h"
 
 namespace views {
 
 typedef ViewsTestBase DesktopNativeWidgetAuraTest;
 
 // Verifies creating a Widget with a parent that is not in a RootWindow doesn't
 // crash.
@@ skipping 133 matching lines @@
   EXPECT_FALSE(cursor_client_a->IsCursorVisible());
   EXPECT_FALSE(cursor_client_b->IsCursorVisible());
 
   // Verify the cursor becomes visible on unlock (since a request
   // to make it visible was queued up while the cursor was locked).
   cursor_client_b->UnlockCursor();
   EXPECT_TRUE(cursor_client_a->IsCursorVisible());
   EXPECT_TRUE(cursor_client_b->IsCursorVisible());
 }
 
+// Verifies FocusController doesn't attempt to access |content_window_| during
+// destruction. Previously the FocusController was destroyed after the window.
+// This could be problematic as FocusController references |content_window_| and
+// could attempt to use it after |content_window_| was destroyed. This test
+// verifies this doesn't happen. Note that this test only failed under ASAN.
+TEST_F(DesktopNativeWidgetAuraTest, DontAccessContentWindowDuringDestruction) {
+  aura::test::TestWindowDelegate delegate;
+  {
+    Widget widget;
+    Widget::InitParams init_params =
+        CreateParams(Widget::InitParams::TYPE_WINDOW);
+    init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+    DesktopNativeWidgetAura* desktop_native_widget_aura =
+        new DesktopNativeWidgetAura(&widget);
+    init_params.native_widget = desktop_native_widget_aura;
+    widget.Init(init_params);
+
+    // Owned by |widget|.
+    aura::Window* window = new aura::Window(&delegate);
+    window->Show();
+    widget.GetNativeWindow()->parent()->AddChild(window);
+
+    widget.Show();
+  }
+}
+
 }  // namespace views