third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-invalid-args.html - Issue 1488763002: Start an empty interface OffScreenCanvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-invalid-args.html

Issue 1488763002: Start an empty interface OffScreenCanvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: handle unsigned->int potential overflow Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-constructor-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-invalid-args-expected.txt » ('j') | third_party/WebKit/Source/core/html/canvas/OffScreenCanvas.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-invalid-args.html

diff --git a/third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-invalid-args.html b/third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-invalid-args.html

new file mode 100644

index 0000000000000000000000000000000000000000..3ce6d637916cf2df1a51ecdd58ec438f75dce683

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-invalid-args.html

@@ -0,0 +1,17 @@

+<!DOCTYPE html>

+<script src="../../resources/js-test.js"></script>

+<script>

+description("Tests that the OffScreenCanvas can handle invalid arguments");

+var width;

+var height;

+var setWidth = Math.pow(2, 31);

Justin Novosad 2015/12/03 17:05:55 Explain that the overflow is an implementation-spe

xidachen 2015/12/03 18:41:40 Done.

+var setHeight = Math.pow(2, 31);

+var canvas1 = new OffScreenCanvas(setWidth, setHeight);

Justin Novosad 2015/12/03 17:05:54 You should also validate setting the size through

xidachen 2015/12/03 18:41:40 The case of setting the size through the attribute

+width = canvas1.width;

+height = canvas1.height;

+shouldBe("width", "setWidth-1");

+shouldBe("height", "setHeight-1");

+</script>