third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-invalid-args.html - Issue 1488763002: Start an empty interface OffScreenCanvas

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-invalid-args.html

Issue 1488763002: Start an empty interface OffScreenCanvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: handle unsigned->int potential overflow Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-constructor-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/canvas/OffScreenCanvas-invalid-args-expected.txt » ('j') | third_party/WebKit/Source/core/html/canvas/OffScreenCanvas.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <script>

	4 description("Tests that the OffScreenCanvas can handle invalid arguments");

	5

	6 var width;

	7 var height;

	8

	9 var setWidth = Math.pow(2, 31);
	Justin Novosad 2015/12/03 17:05:55 Explain that the overflow is an implementation-spe Explain that the overflow is an implementation-specific thing because blink uses signed int internally. xidachen 2015/12/03 18:41:40 Done. Show quoted text On 2015/12/03 17:05:55, Justin Novosad wrote: > Explain that the overflow is an implementation-specific thing because blink uses > signed int internally. Done.
	10 var setHeight = Math.pow(2, 31);

	11 var canvas1 = new OffScreenCanvas(setWidth, setHeight);
	Justin Novosad 2015/12/03 17:05:54 You should also validate setting the size through You should also validate setting the size through the attributes, and you should verify what happens (TypeError exceptions thrown) when passing a negative number, null, an object. xidachen 2015/12/03 18:41:40 The case of setting the size through the attribute Show quoted text On 2015/12/03 17:05:54, Justin Novosad wrote: > You should also validate setting the size through the attributes, and you should > verify what happens (TypeError exceptions thrown) when passing a negative > number, null, an object. The case of setting the size through the attributes is added to the constructor.html, the other cases(invalid args) are added to this test.
	12

	13 width = canvas1.width;

	14 height = canvas1.height;

	15 shouldBe("width", "setWidth-1");

	16 shouldBe("height", "setHeight-1");

	17 </script>

OLD	NEW