ui/views/controls/webview/webview.cc - Issue 1488653002: Fix scroll restoration when exiting fullscreen mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/webview/webview.cc

Issue 1488653002: Fix scroll restoration when exiting fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Accidentally made will_cause_resize always false in previous cleanup. Fixed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/webview/webview.cc

diff --git a/ui/views/controls/webview/webview.cc b/ui/views/controls/webview/webview.cc

index 9a129c04611899777e6d12329c68d3639b1ce2ad..44baa228dc32c69c48a85537ce4c832f9d49f37b 100644

--- a/ui/views/controls/webview/webview.cc

+++ b/ui/views/controls/webview/webview.cc

@@ -294,7 +294,8 @@ void WebView::DidDestroyFullscreenWidget(int routing_id) {

ReattachForFullscreenChange(false);

}

-void WebView::DidToggleFullscreenModeForTab(bool entered_fullscreen) {

+void WebView::DidToggleFullscreenModeForTab(bool entered_fullscreen,

+ bool will_cause_resize) {

if (embed_fullscreen_widget_mode_enabled_)

ReattachForFullscreenChange(entered_fullscreen);

}

« no previous file with comments | « ui/views/controls/webview/webview.h ('k') | ui/views/controls/webview/webview_unittest.cc » ('j') | no next file with comments »