Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: ui/views/controls/webview/webview.cc

Issue 1488653002: Fix scroll restoration when exiting fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Accidentally made will_cause_resize always false in previous cleanup. Fixed Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/views/controls/webview/webview.h ('k') | ui/views/controls/webview/webview_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/controls/webview/webview.h" 5 #include "ui/views/controls/webview/webview.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "content/public/browser/browser_accessibility_state.h" 10 #include "content/public/browser/browser_accessibility_state.h"
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 void WebView::DidShowFullscreenWidget(int routing_id) { 287 void WebView::DidShowFullscreenWidget(int routing_id) {
288 if (embed_fullscreen_widget_mode_enabled_) 288 if (embed_fullscreen_widget_mode_enabled_)
289 ReattachForFullscreenChange(true); 289 ReattachForFullscreenChange(true);
290 } 290 }
291 291
292 void WebView::DidDestroyFullscreenWidget(int routing_id) { 292 void WebView::DidDestroyFullscreenWidget(int routing_id) {
293 if (embed_fullscreen_widget_mode_enabled_) 293 if (embed_fullscreen_widget_mode_enabled_)
294 ReattachForFullscreenChange(false); 294 ReattachForFullscreenChange(false);
295 } 295 }
296 296
297 void WebView::DidToggleFullscreenModeForTab(bool entered_fullscreen) { 297 void WebView::DidToggleFullscreenModeForTab(bool entered_fullscreen,
298 bool will_cause_resize) {
298 if (embed_fullscreen_widget_mode_enabled_) 299 if (embed_fullscreen_widget_mode_enabled_)
299 ReattachForFullscreenChange(entered_fullscreen); 300 ReattachForFullscreenChange(entered_fullscreen);
300 } 301 }
301 302
302 void WebView::DidAttachInterstitialPage() { 303 void WebView::DidAttachInterstitialPage() {
303 NotifyAccessibilityWebContentsChanged(); 304 NotifyAccessibilityWebContentsChanged();
304 } 305 }
305 306
306 void WebView::DidDetachInterstitialPage() { 307 void WebView::DidDetachInterstitialPage() {
307 NotifyAccessibilityWebContentsChanged(); 308 NotifyAccessibilityWebContentsChanged();
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 if (!contents) { 394 if (!contents) {
394 content::WebContents::CreateParams create_params( 395 content::WebContents::CreateParams create_params(
395 browser_context, NULL); 396 browser_context, NULL);
396 return content::WebContents::Create(create_params); 397 return content::WebContents::Create(create_params);
397 } 398 }
398 399
399 return contents; 400 return contents;
400 } 401 }
401 402
402 } // namespace views 403 } // namespace views
OLDNEW
« no previous file with comments | « ui/views/controls/webview/webview.h ('k') | ui/views/controls/webview/webview_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698