content/browser/frame_host/render_frame_host_delegate.h - Issue 1488653002: Fix scroll restoration when exiting fullscreen mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_delegate.h

Issue 1488653002: Fix scroll restoration when exiting fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from scheib@ Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc ('K') | « components/guest_view/browser/guest_view_base.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_delegate.h

diff --git a/content/browser/frame_host/render_frame_host_delegate.h b/content/browser/frame_host/render_frame_host_delegate.h

index ee5aae52bda611ff4eff5537c44a373a427dae52..cc3cd8055f8529341edf2839ff8c97c8cecf20ca 100644

--- a/content/browser/frame_host/render_frame_host_delegate.h

+++ b/content/browser/frame_host/render_frame_host_delegate.h

@@ -153,7 +153,9 @@ class CONTENT_EXPORT RenderFrameHostDelegate {

virtual void EnterFullscreenMode(const GURL& origin) {}

// Notification that the frame wants to go out of fullscreen mode.

- virtual void ExitFullscreenMode() {}

+ // |will_cause_resize| can be false in the case where we exit tab fullscreen

Avi (use Gerrit) 2016/01/05 16:17:57 "can be false"? Please write a comment about when

bokan 2016/01/05 17:15:47 Thanks, I've reworded the whole thing to be more c

+ // into browser fullscreen and thus won't cause bounds to change.

+ virtual void ExitFullscreenMode(bool will_cause_resize) {}

// Let the delegate decide whether postMessage should be delivered to

// |target_rfh| from a source frame in the given SiteInstance. This defaults