Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: content/browser/frame_host/render_frame_host_delegate.h

Issue 1488653002: Fix scroll restoration when exiting fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from scheib@ Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 virtual GeolocationServiceContext* GetGeolocationServiceContext(); 146 virtual GeolocationServiceContext* GetGeolocationServiceContext();
147 147
148 // Gets the WakeLockServiceContext associated with this delegate. 148 // Gets the WakeLockServiceContext associated with this delegate.
149 virtual WakeLockServiceContext* GetWakeLockServiceContext(); 149 virtual WakeLockServiceContext* GetWakeLockServiceContext();
150 150
151 // Notification that the frame wants to go into fullscreen mode. 151 // Notification that the frame wants to go into fullscreen mode.
152 // |origin| represents the origin of the frame that requests fullscreen. 152 // |origin| represents the origin of the frame that requests fullscreen.
153 virtual void EnterFullscreenMode(const GURL& origin) {} 153 virtual void EnterFullscreenMode(const GURL& origin) {}
154 154
155 // Notification that the frame wants to go out of fullscreen mode. 155 // Notification that the frame wants to go out of fullscreen mode.
156 virtual void ExitFullscreenMode() {} 156 // |will_cause_resize| can be false in the case where we exit tab fullscreen
Avi (use Gerrit) 2016/01/05 16:17:57 "can be false"? Please write a comment about when
bokan 2016/01/05 17:15:47 Thanks, I've reworded the whole thing to be more c
157 // into browser fullscreen and thus won't cause bounds to change.
158 virtual void ExitFullscreenMode(bool will_cause_resize) {}
157 159
158 // Let the delegate decide whether postMessage should be delivered to 160 // Let the delegate decide whether postMessage should be delivered to
159 // |target_rfh| from a source frame in the given SiteInstance. This defaults 161 // |target_rfh| from a source frame in the given SiteInstance. This defaults
160 // to false and overrides the RenderFrameHost's decision if true. 162 // to false and overrides the RenderFrameHost's decision if true.
161 virtual bool ShouldRouteMessageEvent( 163 virtual bool ShouldRouteMessageEvent(
162 RenderFrameHost* target_rfh, 164 RenderFrameHost* target_rfh,
163 SiteInstance* source_site_instance) const; 165 SiteInstance* source_site_instance) const;
164 166
165 // Ensure that |source_rfh| has swapped-out RenderViews and 167 // Ensure that |source_rfh| has swapped-out RenderViews and
166 // RenderFrameProxies for itself and for all frames on its opener chain in 168 // RenderFrameProxies for itself and for all frames on its opener chain in
(...skipping 17 matching lines...) Expand all
184 virtual gfx::NativeViewAccessible GetParentNativeViewAccessible(); 186 virtual gfx::NativeViewAccessible GetParentNativeViewAccessible();
185 #endif 187 #endif
186 188
187 protected: 189 protected:
188 virtual ~RenderFrameHostDelegate() {} 190 virtual ~RenderFrameHostDelegate() {}
189 }; 191 };
190 192
191 } // namespace content 193 } // namespace content
192 194
193 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_ 195 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698