content/browser/frame_host/render_frame_host_impl.cc - Issue 1488653002: Fix scroll restoration when exiting fullscreen mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1488653002: Fix scroll restoration when exiting fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Trying to fix test broken on Mac Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc ('K') | « content/browser/frame_host/render_frame_host_delegate.h ('k') | content/browser/web_contents/web_contents_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 18a88eb441030f40bbeb1fb55ee33ec8085b8d4f..09e3dc1a9ff382264241a332aebfc351cab3723e 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -1657,7 +1657,7 @@ void RenderFrameHostImpl::OnToggleFullscreen(bool enter_fullscreen) {

if (enter_fullscreen)

delegate_->EnterFullscreenMode(GetLastCommittedURL().GetOrigin());

else

- delegate_->ExitFullscreenMode();

+ delegate_->ExitFullscreenMode(true);

scheib 2016/01/04 22:26:48 /* will_cause_resize */ true

bokan 2016/01/05 15:37:11 Done.

// The previous call might change the fullscreen state. We need to make sure

// the renderer is aware of that, which is done via the resize message.